Okay
  Public Ticket #1610023
Bug in Osaka Theme functions.php
Closed

Comments

  • Miguel started the conversation

    On file functions.php, line 206, please replace 


            '_ftc_enable_ajax_search' => isset($smof_data['osaka_ajax_search']) ? (int) $smof_data['osaka_ajax_search'] : 1,


    by


            '_ftc_enable_ajax_search' => isset($smof_data['ftc_ajax_search']) ? (int) $smof_data['ftc_ajax_search'] : 1,


    Best regards,

    Miguel Pinto

  •  476
    Criss replied

    Hi,

    Sorry about that, It's our fault.

    We will fix it on next version theme. It's comming soon.

    Thank for your feedback!

    Have a nice day.


    Best regards,

    Charmy  - ThemeFTC technical expert

  • Miguel replied

    I also have more 2 comments:

    1 - Please minify all the vendors JS and CSS resources in folder assets.

    2 - And fix the bug in the could-zoom.js

    https://www.drupal.org/project/commerce_kickstart/issues/1825418

    please change this:

    $mouseTrap = jWin.parent().append(format("<div class='mousetrap' style='background-image:url(\".\");
    z-index:999;position:absolute;width:%0px;height:%1px;left:%2px;top:%3px;\'></div>", sImg.outerWidth(), sImg.outerHeight(), 0, 0)).find(':last');

    by this:

    $mouseTrap = jWin.parent().append(format("<div class='mousetrap' style='background-image:url(\"%0\");
    z-index:999;position:absolute;width:%1px;height:%2px;left:%3px;top:%4px;\'></div>",
    'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7',
    sImg.outerWidth(),sImg.outerHeight(),0,0)).find(':last');

    to avoid javascript error in console.

  • Miguel replied

    Hi Jamie,

    When do you expected release new update?

    Best regards,
    Miguel Pinto

  •  476
    Criss replied

    Hi,

    We are working on update. Thank for your feedback. But we must test it before update.

    It's coming soon, but I not sure all your comment will be change on next update. You known, We have to fix and test in different cases. Considerations between browser platforms ... etc

    If you wanna change it, you can custom it on your child theme. It's the best way for you.

    Thank for all your feedback again.


    Best regards,

    Charmy  - ThemeFTC technical expert